Marvellous. Thanks! -r
On Wed, Oct 10, 2012 at 2:58 PM, Alexander I. Zaytsev <[email protected]>wrote: > Hi, > > No reasons > > Done > https://github.com/nhibernate/nhibernate-core/commit/e1ff2733ac9950efd92fe9be0d9917cb7d19cba6 > > Best Regards, Alex > > > 2012/10/11 Rory Plaire <[email protected]> > >> NHibernate Search maintains a custom subclass of >> NHibernate.Impl.AbstractQueryImpl to query Lucene indexes. As of changeset >> 92ba8462db29e5b1d547d3b8701dddede558f927<https://github.com/nhibernate/nhibernate-core/commit/92ba8462db29e5b1d547d3b8701dddede558f927> >> an >> abstract method GetTranslators was added to AbstractQueryImpl but made >> internal so it cannot be implemented outside of NHibernate Core, breaking >> NHSearch. Was this just a defensive protection, or is there some other >> rationale as to why it is restricted? Can we make it `protected internal` >> to allow subclassing in other assemblies? >> >> -r >> > >
