Too few experienced reviewers/committers familiar with the code and too little time. For me personally I had to first focus on what I started regarding removing some obsolete collection handling. Last week I started to review an issue in the handling of distributed transactions (which is probably among the top problem areas right now) which escalated into an all-night research session. :) Code still to be written.
What could be helpful is if someone could analyze the issues and try to suggest the top 5 most important fixes, based on impact for the wider NHibernate community. This could be done without large knowledge of the code. Regarding NH-3363, I believe there was some discussion on this list where it was felt that it should be possible to have a simpler solution. To my knowledge, no alternative solution have materialized, so I think we should just go ahead with the proposed code. /Oskar 2013/11/22 Kamil Kliczbor <[email protected]> > Oscar, > thx for clarification and encouragement :) > My next question is about the existing pull requests and incorporating > them into the current 4.0 branch: why does it take so long ? > For now there are 56 pull requests and the oldest one was created more > than 2 years ago. > I'am asking because we recently had to deal with the problem that was > fixed by you and put in the separate branch about 11 month ago > https://nhibernate.jira.com/browse/NH-3363. > As you wrote, this is working with green tests, but it was not merged into > main. Being rude: Why? > > W dniu wtorek, 19 listopada 2013 23:22:59 UTC+1 użytkownik Oskar Berggren > napisał: >> >> I'm all for it - there are several such changes already, such as removal >> of non-generic collections and removal of other methods marked deprecated. >> >> Please open (or find) jira requests, and submit changes as pull requests. >> Pull requests that are clean, with one or a few easy to understand commits >> and with no irrelevant changes are much easier to review and apply. :) >> >> /Oskar >> >> >> >> 2013/11/19 Kamil Kliczbor <[email protected]> >> >>> Hi Oscar, >>> I was wondering if we should get rid of all legacy from older versions >>> of framework. In codebase we have class ThreadSafeDictionary that I suppose >>> we could replace with ConcurrentDictionary... What do you think about this ? >>> >>> W dniu sobota, 19 października 2013 12:49:43 UTC+2 użytkownik Oskar >>> Berggren napisał: >>> >>>> NHibernate >>>> 4.0.0.Alpha1<http://www.google.com/url?q=http%3A%2F%2F3.3.3.GA&sa=D&sntz=1&usg=AFQjCNFZTUYEO8qC5FO9FqcnpAVxFd9Vww>is >>>> now available for download from Sourceforge and Nuget. >>>> >>>> http://sourceforge.net/projects/nhibernate/?source=directory<http://www.google.com/url?q=http%3A%2F%2Fsourceforge.net%2Fprojects%2Fnhibernate%2F%3Fsource%3Ddirectory&sa=D&sntz=1&usg=AFQjCNGxmwr6f88ydrdoDb5RBp0BrJcl6A> >>>> >>>> A big thanks to everyone that contributed to this release! >>>> >>>> Summary of changes: >>>> >>>> The main focus of the 4.0 release is to be based on net-4.0, including >>>> removing some older features. Notably, this release uses the ISet<> >>>> interface from the .Net BCL instead of Iesi, and also support for >>>> non-generic persistent collections have been removed. >>>> >>>> The assembly version is 4.0.0.1000, which I expect will change for each >>>> pre-release and then stabilize at 4.0.0.4000 for the GA release. >>>> >>>> Please see the full release notes for more information on breaking >>>> changes: >>>> https://github.com/nhibernate/nhibernate-core/blob/4.0.0.Alp >>>> ha1/releasenotes.txt<https://www.google.com/url?q=https%3A%2F%2Fgithub.com%2Fnhibernate%2Fnhibernate-core%2Fblob%2F4.0.0.Alpha1%2Freleasenotes.txt&sa=D&sntz=1&usg=AFQjCNGoRqHJh4imnsPLZb-KvTVPJHXXfA> >>>> >>>> Full list of changes: >>>> [4.0.0.Alpha1] https://nhibernate.jira.com/issues/?jql=project%20%3D% >>>> 20NH%20AND%20fixVersion%20%3D%20%224.0.0.Alpha1%22%20AND%20stat >>>> us%20in%20%28Resolved%2C%20Closed%29<https://www.google.com/url?q=https%3A%2F%2Fnhibernate.jira.com%2Fissues%2F%3Fjql%3Dproject%2520%253D%2520NH%2520AND%2520fixVersion%2520%253D%2520%25224.0.0.Alpha1%2522%2520AND%2520status%2520in%2520%2528Resolved%252C%2520Closed%2529&sa=D&sntz=1&usg=AFQjCNHxoabj0dtFgBtABEgQ1iQqBt2I3w><https://www.google.com/url?q=https%3A%2F%2Fnhibernate.jira.com%2Fissues%2F%3Fjql%3Dproject%2520%253D%2520NH%2520AND%2520fixVersion%2520in%2520%2528%25223.3.3.CR1%2522%252C%2520%25223.3.3.GA%2522%2529%2520AND%2520status%2520in%2520%2528Resolved%252C%2520Closed%2529&sa=D&sntz=1&usg=AFQjCNFC5p9Jz22wO7UaIbwPVQiBvzqFxg> >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "nhusers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To post to this group, send email to [email protected]. >>> >>> Visit this group at http://groups.google.com/group/nhusers. >>> For more options, visit https://groups.google.com/groups/opt_out. >>> >> >> -- > You received this message because you are subscribed to the Google Groups > "nhusers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/nhusers. > For more options, visit https://groups.google.com/groups/opt_out. > -- --- You received this message because you are subscribed to the Google Groups "nhibernate-development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
