I didn't see anything in hazzik's repo in my quick check. If you don't get
to them first, I'll investigate that one remaining bug causing the two
tests to fail. It would be helpful if you could merge at least the Antlr
update portion you did on your NH-3251 branch, and I'd be happy to bring in
the rest of the changes and the final fix for that "Square" problem if
that's easiest for you.
Are you aware of other things the release is waiting on?
Patrick Earl
On Fri, Aug 1, 2014 at 2:46 AM, Oskar Berggren <oskar.bergg...@gmail.com>
wrote:
> I just remembered hazzik has a branch for NH-3251 also (not based on
> mine). Building but with many failing tests. We might want to compare them.
>
> Please don't merge any of that - was months since I last looked at it so I
> want to jog my memory first.
>
>
> 2014-08-01 10:30 GMT+02:00 Patrick Earl <hyn...@gmail.com>:
>
>> Okay, I fixed the grammar so all the tests pass again. There are still
>> two mysterious test errors that I don't understand. Are those normal?
>>
>> https://github.com/patearl/nhibernate-core/compare/NH-3251
>>
>> I didn't reintegrate it because I wasn't sure of the status of the rest
>> of the Antlr files that were added earlier. You can see the small fixes I
>> made to the .g and .cs files to make things work again.
>>
>> Patrick Earl
>>
>>
>> On Thu, Jul 31, 2014 at 12:14 PM, Patrick Earl <hyn...@gmail.com> wrote:
>>
>>> You can make it compile by changing CommonTreeNodeStream to
>>> BufferedTreeNodeStream.
>>>
>>> Unfortunately even after implementing your "GetType" suggestion, things
>>> seem to be broken, so it appears something has changed in Antlr that
>>> somehow makes our code invalid.
>>>
>>> Perhaps you can make more progress with this info.
>>>
>>> Patrick Earl
>>>
>>
>> --
>>
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "nhibernate-development" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to nhibernate-development+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "nhibernate-development" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to nhibernate-development+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
--
---
You received this message because you are subscribed to the Google Groups
"nhibernate-development" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to nhibernate-development+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
