Hi Ricardo,

i took a first look at the code base.

I think, the first we need is a document which describes how the code can 
be compiled. If you want to build it via msbuild as documented in 
BuildProcess.docx you have to install the MSBuild community tasks and the 
build tasks from CruiseControl and NCover (The latter two maybe removed). I 
used the Combined ArcAngel Workbench solution as starting point and after 
copying the third party dll's you mentioned from my local VisualNHibernate 
installation to the 3d_party_libs folder i was able to compile the sources. 
I'm using Visual Studio 2013 and as i loaded the solution all projects 
where automatically upgrded to .NET Framework 4.0. I think this is the 
reason that i got around 500 errors from R#'s code analysis in the 
ShapeStyle.xaml file. Beneath that there are some other unresolved 
references regarding the DevArt components and some other issues, but id 
did not had the time to investigate it further.

The overall structure of the code seems to be ok (but i just took a glimpse 
at the entity model). But the UI will be much work. First, before i 
referenced the third party dll's R#'s code analysis showed me around 30.000 
errors (mostly from the missing 3rd party code). Second, if you take a look 
at the code in the form classes you will see that there is much logic 
inside. The look and feel of the current UI is bad in my opinion and the 
effort to substitute the UI controls will be the same or even more as if 
you throw away the current UI and build a new one.

So my proposal is:

   - extract the "business" code (extracting the database schema, code 
   generation and so on) and reuse it as far as possible
   - throw away the UI and build a new one

Regards
Klaus

-- 

--- 
You received this message because you are subscribed to the Google Groups 
"nhibernate-development" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to nhibernate-development+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to