You mean, we should have put in place a pattern similar to `ISession`/`ISessionImplementor` for the `IQueryBatchItem`?
Well, we could have. It seems a bit overkill to me though. Le lundi 4 février 2019 09:48:16 UTC+1, Gerke Geurts a écrit : > > Hello Frederic, > > Thank you for your reaction, I was indeed referring to > NHibernate.Multi.IQueryBatch > <https://www.google.com/url?q=https%3A%2F%2Fgithub.com%2Fnhibernate%2Fnhibernate-core%2Fblob%2F5.2.3%2Fsrc%2FNHibernate%2FMulti%2FIQueryBatch.cs&sa=D&sntz=1&usg=AFQjCNF24Mn-_JXIusZd_5hNSOSRzkJAGg> > > and NHibernate.Multi.IQueryBatchItem. > <https://www.google.com/url?q=https%3A%2F%2Fgithub.com%2Fnhibernate%2Fnhibernate-core%2Fblob%2F5.2.3%2Fsrc%2FNHibernate%2FMulti%2FIQueryBatchItem.cs&sa=D&sntz=1&usg=AFQjCNGf5Vi12EFhcI2fIL8L9vto7OYkkA> > > My main point is that the IQueryBatchItem members are not intended for > consumption by NHibernate clients but only by the NHibernate > implementation. For that reason they shouldn't be exposed. > > Kind Regards, > Gerke. > > On Sunday, 3 February 2019 18:28:51 UTC+1, Frédéric Delaporte wrote: >> >> Hello, >> >> As there are no IBatchQuery or IBatchItem in NHibernate, I guess you are >> referring to NHibernate.Multi.IQueryBatch >> <https://www.google.com/url?q=https%3A%2F%2Fgithub.com%2Fnhibernate%2Fnhibernate-core%2Fblob%2F5.2.3%2Fsrc%2FNHibernate%2FMulti%2FIQueryBatch.cs&sa=D&sntz=1&usg=AFQjCNF24Mn-_JXIusZd_5hNSOSRzkJAGg> >> >> and NHibernate.Multi.IQueryBatchItem >> <https://www.google.com/url?q=https%3A%2F%2Fgithub.com%2Fnhibernate%2Fnhibernate-core%2Fblob%2F5.2.3%2Fsrc%2FNHibernate%2FMulti%2FIQueryBatchItem.cs&sa=D&sntz=1&usg=AFQjCNGf5Vi12EFhcI2fIL8L9vto7OYkkA>. >> >> I do not see so much stuff in IQueryBatchItem: including its generic >> counterpart, it has nine members. Maybe is it its >> NHibernate.Multi.ICachingInformation >> <https://github.com/nhibernate/nhibernate-core/blob/master/src/NHibernate/Multi/ICachingInformation.cs> >> >> collection member which you are finding hard to implement. This member is >> optional, it can yield null or an empty list. Handling the cache for a >> multiple query is a bit complex. Feel free to PR simplifications. >> >> Frédéric. >> >> Le samedi 2 février 2019 12:08:13 UTC+1, Gerke Geurts a écrit : >>> >>> Hello, >>> >>> I am updating NHibernate.Shards to NH 5.2 and porting the new query >>> batch interface in the process. The IBatchQuery interface is easy enough to >>> implement, but the IBatchItem interface exposes a lot of internal >>> NHibernate stuff that should not be part of the public API. >>> >>> Cheers, >>> Gerke >>> >>> -- --- You received this message because you are subscribed to the Google Groups "nhibernate-development" group. To unsubscribe from this group and stop receiving emails from it, send an email to nhibernate-development+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
