Steve, thank you for such a good answer!. I'm following this for learn, not just for learn to code, but for learn the management and the decisions. And I'll submit the patch as you said soon!
2009/10/29 Steve Strong <[email protected]> > Due to the nature of Linq, having a large number of tests is pretty much > essential to have confidence that 1) the provider can handle most scenarios > and that 2) when the provider is modified, we don't break existing code. > > Right now, the only test fixture that I've ported over from nhcontrib is > LinqQuerySamples, since this has a good spread of the different types of > query that might be submitted (joins, multiple froms, nested selects, group > joins etc). Getting those core "shapes" working has to be the first port of > call, since they have a significant impact on the structure of the code. > > There are a whole bunch of other tests in nhcontrib that check various > important aspects of the provider but the bulk of them aren't fundamental to > the overall design, so although I'm quite sure that a load of these still > fail, since they are largely "cosmetic" they don't concern me at the moment. > Once I'm happy that the core of the provider is in good shape, then getting > these additional ones working should be really easy. > > If you've already ported the whole nhcontrib test suite over, then that's > great - please submit the patch! Mark any failing tests with the Ignore > attribute and that gives me a great TODO list of what still needs fixing. > > As far as the original query about performance goes, the transparent > caching is already in place so performance with the new Linq provider should > be similar to that of raw HQL; it'll be a smidge slower since generating the > cache key and handling the parameterisation involves a little work, but I > doubt it will be significant given the overhead of the DB hit that's about > to happen. Once I finish the core structure then I will run some profiling > to make sure there's nothing too bad in there :) > > Cheers, > > Steve (feeling the pressure!) > > Twitter <http://twitter.com/srstrong> > Blog <http://blogs.imeta.co.uk/sstrong> > NHibernate Professional > Support<http://www.imeta.co.uk/professional_nhibernate_support.aspx> > > On 22 Oct 2009, at 17:17, José F. Romaniello wrote: > > - Offer to help out with development. Contact Steve or post to the developer >> list. Steve is mostly asking for tests, but given enough volunteers, he >> might consider opening up his dev process a bit. > > > Maybe this is a comment for the dev-list; but I don't see the point of > rewrite a new test suite. > > I have converted the test suite from nhcontrib, to use the new linq > provider and see the half tests failing. There is a bunch of test to fix. > > Why are you writing a new suite instead of adding new tests to the old > suite? > > Sorry If I sound meddlesome, I know "there is no better person to do a job > than who is actually doing". > But I've this doubt. > > > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "nhusers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/nhusers?hl=en -~----------~----~----~----~------~----~------~--~---
