>Too many words and we still waiting a test

Some time ago, after a discussion in another thread, I've said "piece of
cake" and went to my NH sources folder. Looked at it's "red" state (having
few trivial modifications for our own dev environment) and decided that I
don't want to mess up same folder with some side experiments, nor I want to
checkout/make a copy of it - too much friction for me...

Instead I went and installed hgsubversion to test it and ended up converting
one of our svn repos to Mercurial. Hacking it happily since then, having few
local feature/bug-fix branches...

Yeah, this is not related directly to the topic, but it's kind of motivation
story, how DVCS can make OSS contributions easier.

me /rant

Yes, I've tried to work with Mercurial repository provided by you, Fabio.
But it contains only trunk & I do need branches/tags... I've tried also to
import full NH's svn tree to GitHub but it failed. Tried to do the same with
"hg clone" and it went somehow wrong with time-line of branches. In my next
try I'll go with hgsubversion...

me /rant over

After all, I'm just too lazy to write that test...



On Sat, Aug 7, 2010 at 7:52 PM, Fabio Maulo <[email protected]> wrote:

> On Sat, Aug 7, 2010 at 10:02 AM, Frans Bouma <[email protected]> wrote:
>
>>        so my _guess_ (but I'm not sure) is that
>> IEnumerable<T>.Contains(val) isn't implemented in Steve's linq provider,
>> but
>> IQueryable<T>.Contains(val) is.
>>
>>
> Too many words and we still waiting a test
> Frans,
> this is what we have in NHibernate's team implementation:
>
> for CollectionContainsGenerator
> SupportedMethods = new[]
>                    {
>                    ReflectionHelper.GetMethodDefinition(() =>
> Queryable.Contains<object>(null, null)),
>                    ReflectionHelper.GetMethodDefinition(() =>
> Enumerable.Contains<object>(null, null))
>                    };
>
> and for CollectionContainsRuntimeHqlGenerator
>  public bool SupportsMethod(MethodInfo method)
> {
> // the check about the name is to make things a little be fasters
>  return method != null && method.Name == "Contains" &&
> method.IsMethodOf(typeof(ICollection<>));
> }
>
> That is part of our DefaultLinqToHqlGeneratorsRegistry (that can
> be overridden/extended through NH's configuration).
> --
> Fabio Maulo
>
>  --
> You received this message because you are subscribed to the Google Groups
> "nhusers" group.
> To post to this group, send email to [email protected].
> To unsubscribe from this group, send email to
> [email protected]<nhusers%[email protected]>
> .
> For more options, visit this group at
> http://groups.google.com/group/nhusers?hl=en.
>

-- 
You received this message because you are subscribed to the Google Groups 
"nhusers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/nhusers?hl=en.

Reply via email to