Repository method does not dispose the session as it tied to transaction.Thats how NHibernate facility works. We implemented that method based on the ISessionManager in Castle facility see this link http://www.castleproject.org/container/facilities/trunk/nhibernate/usingit.html. It works well when we use with the WCF service. But turned into an error in NServicebus case. I think as you suggest, I have to implement IMessage module to manage the session for nService bus. In WCF, we are managing session using InstanceContext see this one http://www.candland.net/blog/2009/10/27/NHibernateSessionPerRequestUsingCastlesWcfFacility.aspx. But we are not doing anything in case of NService bus. Thats why I said I have to implement the IMessage module.
My WCF service already configuring session factroy specific to wcf per request basis. As my handler is in wcf service, now my question is where to configure the ISessionFactory for nservice bus? In Application_Start event of wcf service? or somewhere else like in this code http://github.com/andreasohlund/Blog/blob/master/NHibernateSample/NHibernateSample.PersisterService/EndpointConfig.cs I have read this article it is related to my problem http://andreasohlund.blogspot.com/2010/02/nhibernate-session-management-in.html. Hope I put lot stuff in here. But I am confused with all these together. Any help would be appreciated. On Sep 2, 2:25 pm, Jason Meckley <[email protected]> wrote: > I would get the problem is lazy loading with a disposed session. you > dispose the session right after you return the value, if you access > any referenced entities lazy loading would fail because the session is > closed. typically using the session like this is a bad practice. you > cannot take advantage of the NH features because the scope of the > session is so narrow. > var(session = factory.OpenSession()) > { > return session.Get<Entity>(id); > > } > > in terms of a service bus (NServiceBus, Rhino, Mass Transit) the > tyipcal usage would look like this: > message arrives > open session, begin transaction > process message > within handler/consumer & various components inject > the current session (created when the message arrived) > message completes > commit (rollback on error) dispose of transaction > and session. > > this means the handlers and services are transient, not singletons. I > use the CurrentSessionContext feature built into NH to manage this for > me. No need for Castle.NhibernateFacility at all. > > Rhino service bus has interface IMessageModule. NSB and MT have the > same component, with a different name. it would look like this > class Uow : IMessageModule > { > public class Uow(ISessionFactory factory) > { > this.factory = factory > } > > public void Init(ITransport transport) > { > transport.MesasgeArrived += OpenSession; > transport.MesasgeCompleted += CompleteSession; > } > > public void Stop(ITransport transport) > { > transport.MesasgeArrived -= OpenSession; > transport.MesasgeCompleted -= CompleteSession; > } > > private bool OpenSession(MessageInformation info) > { > if(CurrentSessionContext.HasBind(factory)) return false; > > var session = factory.OpenSession(); > session.BeginTransaction(); > > CurrentSessionContext.Bind(session) > > return false; > } > > private void CompleteSession(MessageInformation info, Exception e) > { > if(CurrentSessionContext.HasBind(factory) == false) return; > > using(var session = CurrentSessionContext.Unbind(factory)) > using(var tx = session.Transaction) > { > if(e == null) > tx.Commit(); > else > tx.Rollback(); > } > } > > } > > you can then reference the current session using > factory.GetCurrentSession(); > in the config file add > <property name="current_session_context">thread</property> > > On Sep 2, 3:20 pm, Amzath <[email protected]> wrote: > > > > > You are right Fabio. I did remove NHibernate facility and IRepository > > dependency, configured ISessionFactroy, instead of IRepository just > > build query directrly in the code. Did not get any error. There is > > problem in IRepository when used with the Castle NHibernate Facility > > Session manager. But it does not error out consistently and but in > > random when used with WCF and NService bus together. Thank you for > > guideness. > > > But that arises another question, how it closes the session. May not > > be right to ask in this forum? But any help would be appreciated. > > > This is how my IReposity Get implementation looks like > > > [Transaction(TransactionMode.Requires)] > > public virtual T Get<T>(IQuery<T> query) > > { > > using (var session = _sessionManager.OpenSession(DbAlias)) > > { > > return > > query.BuildQuery(session).List<T>().FirstOrDefault(); > > } > > } > > > On Sep 1, 11:26 am, Fabio Maulo <[email protected]> wrote: > > > > You are closing the session in some other place. > > > You will easy found it if you will try to recreate the situation in a > > > pure-NH-100% test without all your wrappers (_sessionManager, > > > _repository). > > > > On Wed, Sep 1, 2010 at 2:22 PM, Amzath <[email protected]> wrote: > > > > As handler does not use MSDTC, I have removed transaction scope from > > > > the code. Now code looks like this but getting same exception. Please > > > > help me on this I have this issue in for last 10 days and could not > > > > figure out why. > > > > > (var session = _sessionManager.OpenSession(DatabaseAli)) > > > > { > > > > using (var tran = > > > > session.BeginTransaction()) > > > > { > > > > var Customer = > > > > _repository.Get(new > > > > CustomerByCustomerId(CustomerUpdate.CustomerIdentifier)); > > > > > UpdateCustomerInfo(Customer, CustomerUpdate); > > > > > UpdateCustomerAccountLimit(Customer, CustomerUpdate); > > > > > UpdateCustomerMethods(Customer, CustomerUpdate); > > > > > _repository.Store(Customer); > > > > > tran.Commit(); > > > > } > > > > } > > > > > On Sep 1, 9:43 am, Amzath <[email protected]> wrote: > > > > > That did not help. Any other way to figure out why is that occuring? > > > > > > On Aug 31, 5:09 pm, Fabio Maulo <[email protected]> wrote: > > > > > > > Put tx.Complete() in the 'using' of the TxScope not in the 'using' > > > > > > of > > > > the > > > > > > session. > > > > > > > On Tue, Aug 31, 2010 at 7:36 PM, Amzath <[email protected]> > > > > wrote: > > > > > > > Getting an error when commiting the transaction. I am opening and > > > > > > > closing the session properly. But I dont know why this error > > > > > > > occurs? > > > > > > > Can any one helps me? > > > > > > > > Code: > > > > > > > > using (var tx = new > > > > > > > TransactionScope(TransactionScopeOption.Suppress)) > > > > > > > using (var session = > > > > > > > _sessionManager.OpenSession(DatabaseAli)) > > > > > > > { > > > > > > > using (var tran = > > > > > > > session.BeginTransaction()) > > > > > > > { > > > > > > > > var Customer = > > > > > > > _repository.Get(new > > > > > > > CustomerByCustomerId(CustomerUpdate.CustomerIdentifier)); > > > > > > > > UpdateCustomerInfo(Customer, CustomerUpdate); > > > > > > > > UpdateCustomerAccountLimit(Customer, CustomerUpdate); > > > > > > > > UpdateCustomerMethods(Customer, CustomerUpdate); > > > > > > > > _repository.Store(Customer); > > > > > > > > tran.Commit(); > > > > > > > } > > > > > > > tx.Complete(); > > > > > > > } > > > > > > > > Error: > > > > > > > > 2010-08-31 16:01:41,687 [Worker.5] ERROR > > > > > > > MyTest.ConsumerApp.Services.Handlers.CustomerUpdater [(null)] - > > > > > > > End: > > > > > > > HandlingMessage: Failed handling CustomerUpdate message from > > > > > > > System.ObjectDisposedException: Cannot access a disposed object. > > > > > > > Object name: 'AdoTransaction'. > > > > > > > at NHibernate.Transaction.AdoTransaction.CheckNotDisposed() > > > > > > > at NHibernate.Transaction.AdoTransaction.Commit() > > > > > > > at > > > > > MyTest.ConsumerApp.Services.Handlers.CustomerUpdater.Handle(CustomerUpdate > > > > > > > CustomerUpdate) in C:\MyTest\trunk\ConsumerApp\Services\Handlers > > > > > > > \CustomerUpdater.cs:line 113 > > > > > > > > -- > > > > > > > You received this message because you are subscribed to the Google > > > > Groups > > > > > > > "nhusers" group. > > > > > > > To post to this group, send email to [email protected]. > > > > > > > To unsubscribe from this group, send email to > > > > > > > [email protected]<nhusers%[email protected]> > > > > <nhusers%[email protected]<nhusers%252bunsubscr...@googlegroups.com> > > > > > > > > > > > > . > > > > > > > For more options, visit this group at > > > > > > >http://groups.google.com/group/nhusers?hl=en. > > > > > > > -- > > > > > > Fabio Maulo- Hide quoted text - > > > > > > > - Show quoted text -- Hide quoted text - > > > > > > - Show quoted text - > > > > > -- > > > > You received this message because you are subscribed to the Google > > > > Groups > > > > "nhusers" group. > > > > To post to this group, send email to [email protected]. > > > > To unsubscribe from this group, send email to > > > > [email protected]<nhusers%[email protected]> > > > > . > > > > For more options, visit this group at > > > >http://groups.google.com/group/nhusers?hl=en. > > > > -- > > > Fabio Maulo- Hide quoted text - > > > > - Show quoted text -- Hide quoted text - > > - Show quoted text - -- You received this message because you are subscribed to the Google Groups "nhusers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/nhusers?hl=en.
