Thanks so much! I'm definitely not an NHibernate expert (I used Castle ActiveRecord for the website, so I just had some basic NH experience).. I'll check into each of the issues you've mentioned and look into a better solution.
Mike On Wed, Feb 19, 2014 at 12:58 AM, Ramon Smits <[email protected]> wrote: > > Hi I just viewed your database adapter : > https://github.com/KitchenPC/core/blob/master/src/DB/DatabaseAdapter.cs > > 1. I don't know how you define your units of work but I see that you do > both transaction and session management within this same class. IMHO its > doing to much especially regaring transactions and methods. I would apply > seperation of concern to make this much more managable. > > 2. You are using seperate DB and Model entities and mapping them which > just creates additional work. > > 3. Your 'CreateShoppingList' method does a Save for each item. You could > define a new aggregate where NHibernate would persist the collection > automatically. > > 4. The 'UpdateShoppingList' does its own delete, update and insert > tracking which you should delegate to NHibernate as NHibernate does change > tracking for you. You are not really using the benefits of an ORM. > > > I hope these tips help in improving your solution. > > -- Ramon > > > > -- Ramon > > > On Tue, Feb 18, 2014 at 11:09 PM, Mike Christensen <[email protected]>wrote: > >> This is somewhat off topic, but I thought I'd share in case anyone is >> interested. >> >> I've just released a new open source project for working with recipes, >> shopping lists and menus. This includes structures for representing these >> concepts, code to classify recipes, code to parse recipes and ingredient >> usages from natural language, and code to aggregate recipes together to >> find common ingredients and usages. >> >> It can be configured to save and load data from a database using a >> database adapter, and the default database adapter is built using Fluent >> NHibernate. >> >> If you're interested in checking out the project, working on another >> project that deals with recipes or shopping lists, or want to contribute in >> any way to the effort, please feel free! >> >> The code is at: >> >> https://github.com/KitchenPC/core >> >> The README file contains links on how to get started. Thanks! >> >> Mike >> >> -- >> You received this message because you are subscribed to the Google Groups >> "nhusers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To post to this group, send email to [email protected]. >> Visit this group at http://groups.google.com/group/nhusers. >> For more options, visit https://groups.google.com/groups/opt_out. >> > > -- > You received this message because you are subscribed to the Google Groups > "nhusers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/nhusers. > For more options, visit https://groups.google.com/groups/opt_out. > -- You received this message because you are subscribed to the Google Groups "nhusers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/nhusers. For more options, visit https://groups.google.com/groups/opt_out.
