Almost no tests covering the class: DefaultDynamicLazyFieldInterceptor

I had to kind work it out from the only other test case available.

Luckily it appears that you can just wrap a class in a proxy and use it 
without needing the DB etc...

If the PR isn't what your looking for then at least you can use it as a 
starting point.

Thanks, Mark

On Friday, July 29, 2016 at 3:06:27 PM UTC+1, Mark Perry wrote:
>
> https://github.com/nhibernate/nhibernate-core/pull/487
>
> On Friday, July 29, 2016 at 2:58:46 PM UTC+1, Oskar Berggren wrote:
>>
>> Start using showbuildmenu.bat.
>>
>> The fix seems small - woulld be great if you could provide a failing test 
>> case as that is required to incorporate the fix. Hopefully you can find 
>> something in the test-project that verifies the unwrapping for the case 
>> that _does_ work, and add another case there perhaps.
>>
>> /Oskar
>>
>> 2016-07-29 14:04 GMT+01:00 Mark Perry <[email protected]>:
>>
>>> Fixed my problem:
>>>
>>> Changed this
>>>
>>> https://github.com/nhibernate/nhibernate-core/blob/378be39482e36a419e3e96fea54de211ef9580ce/src/NHibernate/Intercept/DefaultDynamicLazyFieldInterceptor.cs#L53
>>>  
>>>
>>> to:
>>>
>>> object returnValue;
>>> try
>>> {
>>>   returnValue = info.InvokeMethodOnTarget();
>>> }
>>> catch (TargetInvocationException ex)
>>> {
>>>   throw ReflectHelper.UnwrapTargetInvocationException(ex);
>>> }
>>> return returnValue;
>>>
>>> If I can manage it I'll try and submit a PR but I can't even get NH to 
>>> build from source from a fresh download due to AssemblyInfo issues.
>>>
>>> Thanks, Mark
>>>
>>> -- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "nhusers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to [email protected].
>>> To post to this group, send email to [email protected].
>>> Visit this group at https://groups.google.com/group/nhusers.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"nhusers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/nhusers.
For more options, visit https://groups.google.com/d/optout.

Reply via email to