It is interesting. It does not apply to me so I am just lurking. On Mon, Aug 22, 2022 at 8:04 AM Detlev Zundel <[email protected]> wrote:
> It seems I am mostly talking to myself here ;) > > > I wrote: > > > > [...] > > > >> If I am not mistaken again, then this commit removed a file > >> "moment-with-locales.min.js" and may be the reason why the created > >> bundle does not include the "moment" code required by the index.html > >> file. > >> > >> So can someone tell me if this reasoning is correct and how to correctly > >> fix this? > > > > So I think I have found the core problem. Commit f1d480d8 (Fix #3232 — > > switch to Luxon for fancy dates, 2020-04-15) in Nikola switched to a > > different handling of fancy dates altogether and the zen theme missed > > out on this change. The fact that nobody complained may point to the > > fact that I am the only user of this theme :| > > > > I'll try to come up with a proper fix for this soon. > > To properly document the problem, I opened an issue it github: > > https://github.com/getnikola/nikola-themes/issues/211 > > And a pull-request including a fix for this issue: > > https://github.com/getnikola/nikola-themes/pull/209 > > In my local repository I do have some more enhancements on top of this > (update of fontaweseom and forkawesome and adding 'updated' handling) > and once the base goes in, I can open subsequent pull requests. Or > is it better to put all the new stuff into one pull-request? I did not > do this yet as my experience shows that people like to deal with smaller > units that are more clearly separated, but maybe this depends on the > project. > > Any comment greatly appreciated! > > Best wishes > Detlev > > -- > Referee's report: This paper contains much that is new and much that > is true. Unfortunately, that which is true is not new and that which > is new is not true. > > -- > You received this message because you are subscribed to the Google Groups > "nikola-discuss" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/nikola-discuss/87czcs2uc7.fsf%40member.fsf.org > . > -- You received this message because you are subscribed to the Google Groups "nikola-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/nikola-discuss/CAEHvH-cC5VSWzApiG1U8rbZHF3sruKB1ypyMWdmrq2gbxv4NBw%40mail.gmail.com.
