> But I encourage, implore, welcome, people to beat on the code to improve it 
> and make it faster. What idioms are faster than the ones I used, etc.

Here is [my 
gist](https://gist.github.com/narimiran/f9c1df45036cff34a725baad2e89af44) \- I 
took your improved version, went quickly through it, and have made mostly 
**cosmetic changes** \- theoretically this might be a bit quicker (e.g. 
variables declared outside of the loops), but I don 't expect to see any 
difference in practice.

Some of the stuff I have changed:

  * comments above function declarations are now docstrings for those functions 
(comments starting with ##)
  * a new type to make return type of genPGparameters more readable
  * variables are declared outside of the loops
  * var and let blocks
  * use a ..< b instead of a .. b-1
  * added some breathing room 



I haven't changed any logic (or I think so), but please test if it works as it 
should.

Reply via email to