* There are currently 144 open pull requests
  * the last commit was 4 days ago, 
[https://github.com/nim-lang/Nim/commit/269b957e2968345a4c9a5037ab97ab726135a921](https://github.com/nim-lang/Nim/commit/269b957e2968345a4c9a5037ab97ab726135a921)
  * the faster PR's get reviewed/merged, the more likely a PR author will be to 
contribute more PR's, leading to increased rate of bug fixes and enhancements.



Likewise, a slow PR process has the exact opposite effect.

A number of PR's have either 0 reviews or are waiting for a merge or further 
comments after all comments are addressed; then time passes by and bitrot 
happens, causing them to be un-mergeable even if they initially were when they 
were last updated.

What can be done to improve this?

  * encourage more reviews from everyone
  * more trusted contributors with commit rights
  * to increase number of committers while keeping high quality bar, I suggest 
this could be done on a per-area-of-expertise basis, where a committer can 
merge a PR only if the patched files are within his area of expertise; this 
could be done formally or informally, where each committer is co-owner of a set 
of directories / files. This works well in large organizations (eg google) and 
some open source projects.
  * what if a bad PR gets merged?



we can always revert; impact will be small so long revert happens shortly after 
the merge and in between 2 releases. Obviously CI prevents "obvious" bad merges 
already. IMO the benefit of increased velocity in getting PR's merged outweighs 
the cost of occasional PRs that need to be reverted.

Reply via email to