Currently, looking at 
[https://github.com/nim-lang/Nim/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc](https://github.com/nim-lang/Nim/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc)
 it's not clear which PR's are ready for review vs still being worked on:

  * using draft vs not draft is not good for that: github recently allowed 
marking a non-draft PR as draft, but that feature is unavailable if you're not 
a project member; also a PR that merely needs to address comments shouldn't 
really be considered a draft anyways (it works but just needs to address 
comments)
  * using CI passing vs failing is not good either because of flaky tests, and 
because a PR could have pending unaddressed comments and still be green



# proposal

  * add a new "PTAL" github tag, with the meaning: either PR is ready for 
review for the 1st time, or, after a round of review and after all comments 
were addressed, it's ready again for another round; and all failures are (to PR 
author's knownledge) unrelated to the PR
  * users who don't have permissions to add a tag to their own PR can add 
[PTAL] to their PR title



the feature would be optional to use, but PR authors who want to use it can, to 
increase visibility of their PR (once they've addressed all comments) without 
having to ping reviewers

it makes those PR's easy to search for and we can easily filter by those in 
github search UI

# note

PTAL simply means "Please Take Another Look", this practice is common both in 
tech companies as well as in open source, eg:

  * 
[https://su2code.github.io/docs/Code-Review](https://su2code.github.io/docs/Code-Review)/
  * 
[https://medium.engineering/code-reviews-at-medium-bed2c0dce13a](https://medium.engineering/code-reviews-at-medium-bed2c0dce13a)



and unfortunately github doesn't have this feature builtin, so a tag is the 
best workaround 

Reply via email to