I've removed the rec and incorporated the version directly into the fetchurl function. I was using one of the research papers as a guide when initially writing it. I have also added some meta data and created directory patches (one of nixos and one of nixpkgs). If it's easier to do a per file patch let me know. (I also did it in the correct order this time - oops)
On a side note I'm having trouble with the patchutils package, so I can't test it. Please let me know if there is anything else I can do. I'm playing around with an ati-binary (fglrx) package because I have a 4850 ati card that is not working with the open source drivers as of now. John On Tue, Jan 20, 2009 at 12:14 PM, Ludovic Courtès <[email protected]> wrote: > Hello, and welcome on board! ;-) > > "John Altobelli" <[email protected]> > writes: > >> --- nixpkgs/pkgs/desktops/enlightenment/default.nix 2009-01-19 >> 18:37:11.000000000 -0500 >> +++ /dev/null 2009-01-19 18:43:59.148001034 -0500 >> @@ -1,12 +0,0 @@ >> -{ stdenv, fetchurl, pkgconfig, x11, xlibs, dbus, imlib2, freetype }: > > Your patch is reversed (it should be pluses, not minuses), but that's a > detail. > >> -let version = "0.16.8.15"; in >> -stdenv.mkDerivation (rec { >> - name = "enlightenment-${version}"; > > You don't need `rec' (the recursive attribute set constructor) here. Or > you could discard `version' and write: > > rec { > name = "enlightenment-0.16..."; > url = "mirror://.../${name}.tar.gz"; > } > > The expression also lacks a `meta' attribute, which is quite helpful. > > Other than that, the patch looks good to me! > > Thanks, > Ludo'. > > _______________________________________________ > nix-dev mailing list > [email protected] > https://mail.cs.uu.nl/mailman/listinfo/nix-dev >
nixos.patch
Description: Binary data
nixpkgs.patch
Description: Binary data
_______________________________________________ nix-dev mailing list [email protected] https://mail.cs.uu.nl/mailman/listinfo/nix-dev
