> Hi Karn,
>
> just a minor nitpick: static libraries are disabled by default by the
> generic builder. If you need static libraries, the way to do it, IMHO,
>
> is to set:
> dontDisableStatic = yes;
>
> The advantage is that the --disable-static flag won't be passed to
> configure at all, whereas your patch ends up configuring the package
> with "--disable-static --enable-static", which feels awkward.
>
> Take care,
> Peter
Thank you very much Peter! The way you have shown is much better. Attached
is a new patch with your improvement.
diff --git a/pkgs/development/compilers/urweb/default.nix b/pkgs/development/compilers/urweb/default.nix
index b88df77..8f2a33f 100644
--- a/pkgs/development/compilers/urweb/default.nix
+++ b/pkgs/development/compilers/urweb/default.nix
@@ -24,6 +24,8 @@ stdenv.mkDerivation rec {
export GCCARGS="-I${mysql}/include/mysql -I${postgresql}/include -I${sqlite}/include -L${libmhash}/lib -L${mysql}/lib/mysql -L${postgresql}/lib -L${sqlite}/lib"
'';
+ dontDisableStatic = true;
+
meta = {
description = "Ur/Web supports construction of dynamic web applications backed by SQL databases.";
longDescription = ''
diff --git a/pkgs/development/libraries/libmhash/default.nix b/pkgs/development/libraries/libmhash/default.nix
index cd02629..565340a 100644
--- a/pkgs/development/libraries/libmhash/default.nix
+++ b/pkgs/development/libraries/libmhash/default.nix
@@ -17,6 +17,8 @@ stdenv.mkDerivation rec {
version = "0.9.9.9";
name = "${pname}-${version}";
+ dontDisableStatic = true;
+
src = fetchurl {
url = "mirror://sourceforge/${pname}/${name}.tar.bz2";
sha256 = "1w7yiljan8gf1ibiypi6hm3r363imm3sxl1j8hapjdq3m591qljn";
_______________________________________________
nix-dev mailing list
[email protected]
https://mail.cs.uu.nl/mailman/listinfo/nix-dev
