Corey O'Connor wrote: > On Sat, Mar 17, 2012 at 8:00 PM, Shea Levy <[email protected]> wrote: >> On 3/17/12 10:37 PM, Corey O'Connor wrote: >>> >>> Thanks for the info! >>> What happens when we hit Ship It? >> >> >> It adds a review that basically means "I don't mind if you commit this". >> In a 'no-reply-is-no-ok' project like NixOS this kind of feedback is >> necessary. > > What happens in terms of process? Nothing. Just anybody can see that more than 1 person thinks that this code can be committed.
> Who then commits the patches? Normally, the one who submitted the patch. If he has no commit access, he can add "commit, please" comment. > Are they notified by email or ...? It seems that this type of notification e-mails was turned off. I've turned it on a minute ago. -- Yury G. Kudryashov, mailto: [email protected] _______________________________________________ nix-dev mailing list [email protected] http://lists.science.uu.nl/mailman/listinfo/nix-dev
