Hi Andreas and Mateusz, great work!
Andreas Herrmann <[email protected]> writes: > On 15 June 2014 22:11, Mateusz Kowalczyk <[email protected]> wrote: >> On 06/15/2014 09:09 PM, Andreas Herrmann wrote: >> > On 15 June 2014 02:28, Mateusz Kowalczyk <[email protected]> >> wrote: >> >> On 06/14/2014 11:17 PM, Andreas Herrmann wrote: >> > Okay, it runs on all python versions except pypy. Which is to be >> expected. >> > However, the pypy branch seems to be somewhat broken. The build failed at >> > setuptools long before it reached my package. Thx for reporting, I'm working on nixos python test suites and made a note to investigate. >> > I dug a little deeper and found that the problem was actually rooted in >> the >> > hdf5 package. pytables needs it to be built with zlib. I put that in, and >> > also fixed the szip package. However, both could be called optional >> > dependencies on hdf5. Do you know, how I can make pytables depend on hdf5 >> > with a certain set of parameters? Or are these things handled through >> > comments and documentation? >> > >> > To be more explicit: say hdf5 has the parameters `{ stdenv, fetchurl, >> zlib >> > ? null, szip ? null }`. How can I make pytables depend on hdf5 in such a >> > way, that it requires `zlib != null`, but doesn't care about `szip`? >> >> I can't say for sure but I'd imagine you'd simply override it as usual. >> Say you have pytables at >> development/python-modules/pytables.default.nix: your entry to >> python-modules.nix could look like >> >> pytables = callPackage ../development/python-modules/pytables { >> hdf5 = pkgs.hdf5.override { zlib = pkgs.zlib; }; >> }; The solution looks good to me. However, from a brief look it feels that one would want the default hdf5 package to be built with szip and zlib. What do you think? In that case you would keep the hdf5 expression as is (so people can disable), you would not need the override here, and would pass szip and zlib to hdf5 in all-packages. Waiting for you comment and/or changes and would then merge. florian -- Florian Friesdorf <[email protected]> GPG FPR: 7A13 5EEE 1421 9FC2 108D BAAF 38F8 99A3 0C45 F083 Jabber/XMPP: [email protected] IRC: chaoflow on freenode,ircnet,blafasel,OFTC
pgpd_DtDXR4cn.pgp
Description: PGP signature
_______________________________________________ nix-dev mailing list [email protected] http://lists.science.uu.nl/mailman/listinfo/nix-dev
