Nope. The build failure is a consequence of the fix. If package X does not _directly_ depend on Y, then Y must not appear in build inputs, for any reason. If the build fails, it's because some .la file is broken somewhere, as said.
On Fri, Jul 31, 2015 at 1:01 AM, Bjørn Forsman <[email protected]> wrote: > On 29 July 2015 at 15:38, Luca Bruno <[email protected]> wrote: > > To everyone, it's not correct to add openssl to buildInputs or > > propagatedBuildInputs. > > > > It's most probably a broken .la file in some package (like I fixed > > recently libarchive) that is propagating -lcrypto without a proper -L > flag. > > > > So please, before adding build inputs like this and then you don't have > > any clue, at least ping someone for review. > > I did git bisect on the evolution-data-server build failure (for which > I added openssl dependency to fix -lcrypto breakage, and was later > reverted) and arrived at this: > > $ git show > commit 689897088ce3e9a80edfff10866a8c05459e0c1d > Author: Eelco Dolstra <[email protected]> > Date: Sun Jul 26 12:44:26 2015 +0200 > > cups: Don't depend on OpenSSL > > Afaict, it doesn't use OpenSSL, just GNU/TLS. > > diff --git a/pkgs/misc/cups/default.nix b/pkgs/misc/cups/default.nix > index 0018a27..bcd27d6 100644 > --- a/pkgs/misc/cups/default.nix > +++ b/pkgs/misc/cups/default.nix > @@ -1,4 +1,4 @@ > -{ stdenv, fetchurl, pkgconfig, zlib, libjpeg, libpng, libtiff, pam, > openssl > +{ stdenv, fetchurl, pkgconfig, zlib, libjpeg, libpng, libtiff, pam > , dbus, acl, gmp, xdg_utils > , libusb ? null, gnutls ? null, avahi ? null, libpaper ? null > }: > @@ -19,7 +19,7 @@ stdenv.mkDerivation { > buildInputs = [ pkgconfig zlib libjpeg libpng libtiff libusb gnutls > avahi libpaper ] > ++ optionals stdenv.isLinux [ pam dbus.libs acl xdg_utils ] ; > > - propagatedBuildInputs = [ openssl gmp ]; > + propagatedBuildInputs = [ gmp ]; > > configureFlags = [ > "--localstatedir=/var" > > > So it might be missing openssl dependency after all. > > /Bjørn > -- NixOS Linux <http://nixos.org>
_______________________________________________ nix-dev mailing list [email protected] http://lists.science.uu.nl/mailman/listinfo/nix-dev
