Branch: refs/heads/master
  Home:   https://github.com/NixOS/nix
  Commit: 054be5025762c5e1c7e853c4fa5d7eed8da1727f
      
https://github.com/NixOS/nix/commit/054be5025762c5e1c7e853c4fa5d7eed8da1727f
  Author: Eelco Dolstra <eelco.dols...@logicblox.com>
  Date:   2016-09-16 (Fri, 16 Sep 2016)

  Changed paths:
    M src/libutil/logging.cc
    M src/libutil/util.cc
    M src/libutil/util.hh

  Log Message:
  -----------
  printMsg(): Don't check for interrupts

Having the logger function potentially throw exceptions is
Heisenbuggy.


  Commit: 75989bdca773eedb8b8d1cc8a7675900358acd25
      
https://github.com/NixOS/nix/commit/75989bdca773eedb8b8d1cc8a7675900358acd25
  Author: Eelco Dolstra <eelco.dols...@logicblox.com>
  Date:   2016-09-16 (Fri, 16 Sep 2016)

  Changed paths:
    M src/libstore/binary-cache-store.cc
    M src/libstore/binary-cache-store.hh
    M src/libstore/download.cc
    M src/libstore/download.hh
    M src/libstore/http-binary-cache-store.cc
    M src/libstore/local-binary-cache-store.cc
    M src/libstore/local-store.cc
    M src/libstore/local-store.hh
    M src/libstore/misc.cc
    M src/libstore/remote-store.cc
    M src/libstore/remote-store.hh
    M src/libstore/s3-binary-cache-store.cc
    M src/libstore/store-api.cc
    M src/libstore/store-api.hh
    M src/libutil/util.cc
    M src/libutil/util.hh

  Log Message:
  -----------
  Make computeFSClosure() single-threaded again

The fact that queryPathInfo() is synchronous meant that we needed a
thread for every concurrent binary cache lookup, even though they end
up being handled by the same download thread. Requiring hundreds of
threads is not a good idea. So now there is an asynchronous version of
queryPathInfo() that takes a callback function to process the
result. Similarly, enqueueDownload() now takes a callback rather than
returning a future.

Thus, a command like

  nix path-info --store https://cache.nixos.org/ -r 
/nix/store/slljrzwmpygy1daay14kjszsr9xix063-nixos-16.09beta231.dccf8c5

that returns 4941 paths now takes 1.87s using only 2 threads (the main
thread and the downloader thread). (This is with a prewarmed
CloudFront.)


Compare: https://github.com/NixOS/nix/compare/2e1493037b06...75989bdca773
_______________________________________________
nix-commits mailing list
nix-comm...@lists.science.uu.nl
http://lists.science.uu.nl/mailman/listinfo/nix-commits

Reply via email to