Branch: refs/heads/nixpart
  Home:   https://github.com/NixOS/nixpkgs
  Commit: b73449b002dd45948a43a7dbe8a69fc2e0ac9f08
      
https://github.com/NixOS/nixpkgs/commit/b73449b002dd45948a43a7dbe8a69fc2e0ac9f08
  Author: aszlig <[email protected]>
  Date:   2016-12-28 (Wed, 28 Dec 2016)

  Changed paths:
    M nixos/modules/tasks/storage.nix

  Log Message:
  -----------
  nixos/storage: Refactor size/grow options

The grow option now is no longer necessary, because the same effect can
be achieved by setting size to "fill". This also means that setting the
size option is now mandatory, thus it doesn't have a default value.

Instead of allowing a string for specifying size units we now use
attribute sets to do so, for example:

storage.partition.foo.size.mb = 123;

This would result into the "foo" partition being created with a size of
123 MB.

Of course it's possible to specify several units, for example:

storage.partition.foo.size = { mb = 123; kb = 456; b = 789; };

Now the type checking is also improved, so it actually shows more
information about which value is incorrectly set and why.

Signed-off-by: aszlig <[email protected]>


  Commit: a5fd32ed75444658a703a95c9f4b8e14134f7baa
      
https://github.com/NixOS/nixpkgs/commit/a5fd32ed75444658a703a95c9f4b8e14134f7baa
  Author: aszlig <[email protected]>
  Date:   2016-12-28 (Wed, 28 Dec 2016)

  Changed paths:
    M nixos/tests/storage.nix

  Log Message:
  -----------
  nixos/tests/storage: Fix size/grow definitions

Use the new way to specify sizes as implemented in the previous commit.

Right now we only specify megabytes in the tests, so the tests do not
serve as very good examples on different size specifications which we
need to change soon.

Signed-off-by: aszlig <[email protected]>


  Commit: bdaf7adcbc8b8107e0d2756d192e7a29aeb3c380
      
https://github.com/NixOS/nixpkgs/commit/bdaf7adcbc8b8107e0d2756d192e7a29aeb3c380
  Author: aszlig <[email protected]>
  Date:   2016-12-28 (Wed, 28 Dec 2016)

  Changed paths:
    M nixos/modules/tasks/storage.nix

  Log Message:
  -----------
  nixos/storage: Don't use commonOptions for btrfs

BTRFS volumes are spanning over a range of physical devices and thus the
size option really doesn't apply here. Neither does it make sense to
have ordering.

In the future however we might want to allow setting a quota for a
particular volume.

Signed-off-by: aszlig <[email protected]>


  Commit: 37ca379834a616304df70533f7b2723c98e170c2
      
https://github.com/NixOS/nixpkgs/commit/37ca379834a616304df70533f7b2723c98e170c2
  Author: aszlig <[email protected]>
  Date:   2016-12-28 (Wed, 28 Dec 2016)

  Changed paths:
    M nixos/tests/storage.nix

  Log Message:
  -----------
  nixos/tests/storage: Always show stdout of nixpart

Right now we have a print() at the end of the realize() function within
nixpart, which is going to print the device tree to stdout.

While I could print it to stderr instead it nevertheless make sense to
always show all the results from nixpart, regardless of whether it has
failed or not.

Signed-off-by: aszlig <[email protected]>


  Commit: 8ec55bf596d863db9e7c340479d744f9facc658b
      
https://github.com/NixOS/nixpkgs/commit/8ec55bf596d863db9e7c340479d744f9facc658b
  Author: aszlig <[email protected]>
  Date:   2016-12-28 (Wed, 28 Dec 2016)

  Changed paths:
    M nixos/tests/storage.nix

  Log Message:
  -----------
  nixos/tests/storage/ext: Fix check of boot sector

This was a typo I did in the first implementation and we really want to
check for the existance of a MBR on /dev/vdb instead of /dev/vdb4.

Signed-off-by: aszlig <[email protected]>


  Commit: 8c9d3192f07e2bcdf8d48197cef2343283e4d62c
      
https://github.com/NixOS/nixpkgs/commit/8c9d3192f07e2bcdf8d48197cef2343283e4d62c
  Author: aszlig <[email protected]>
  Date:   2016-12-28 (Wed, 28 Dec 2016)

  Changed paths:
    M nixos/modules/tasks/storage.nix

  Log Message:
  -----------
  nixos/storage: Use bytes for plain int sizes

It makes more sense to default to plain bytes, so that we have the
lowest unit and also the principle of least astonishment because people
would usually assume if the didn't read the description of the option
that the amount is in bytes rather than some arbitrary value.

However, in terms of specifying sizes for partitioning, MiB or MB would
make more sense because it's highly unlikely that people want to have a
partition that's only a few bytes large.

Nevertheless having MiB vs. MB is probably also confusing because it's
clear whether people would assume the default based on 1024 units or
units of 1000.

Signed-off-by: aszlig <[email protected]>


  Commit: 372fa21422c179c7710b0fd8ae72e96dad9fea73
      
https://github.com/NixOS/nixpkgs/commit/372fa21422c179c7710b0fd8ae72e96dad9fea73
  Author: aszlig <[email protected]>
  Date:   2016-12-28 (Wed, 28 Dec 2016)

  Changed paths:
    M nixos/tests/storage.nix

  Log Message:
  -----------
  nixos/tests/storage: Use MiB for test sizes

The default size unit that's printed by the blivet device tree
representation is MiB, GiB and so on. This makes it more obvious whether
the correct size was used for partitioning without the need to convert
between mebibytes and megabytes.

Signed-off-by: aszlig <[email protected]>


  Commit: d39dd4039d27fd0554d19a25943645ddcbec971d
      
https://github.com/NixOS/nixpkgs/commit/d39dd4039d27fd0554d19a25943645ddcbec971d
  Author: aszlig <[email protected]>
  Date:   2016-12-28 (Wed, 28 Dec 2016)

  Changed paths:
    M pkgs/tools/filesystems/nixpart/default.nix

  Log Message:
  -----------
  nixpart: Update to latest master version

This incorporates the changes revolving around the size option.

Signed-off-by: aszlig <[email protected]>


Compare: https://github.com/NixOS/nixpkgs/compare/81152a51a4eb...d39dd4039d27
_______________________________________________
nix-commits mailing list
[email protected]
http://lists.science.uu.nl/mailman/listinfo/nix-commits

Reply via email to