As the person submitting the PR, there is a checkbox (that is checked by default) that grants reviewers access to the branch.
As a reviewer, the procedure is to git remote add $user [email protected]: $user/nixpkgs.git. Checkout the branch and push the commits that you want. Force-push is not allowed for the reviewer on that branch. To make things a bit faster, install the hub <https://hub.github.com/> CLI, then you can hub remote add $user which translates to the same as above. On Sat, 14 Jan 2017 at 09:54 Benno Fünfstück <[email protected]> wrote: > > Finally during the review, the reviewer was pushing style fixes to the > PR. It was probably as quick as leaving a comment and made the whole > process much more inclusive, we were actually working together to get this > merged. > > How does this work? Did you need to give him access to your repo for this, > or is there some github-integrated way that I don't know of to push changes > to branches of a PR? > > zimbatm <[email protected]> schrieb am Fr., 6. Jan. 2017 um 21:17 Uhr: > > No not that I know of. It would be awkward to maintain because homebrew > expects to be installed in /usr/local and not in the /nix/store. It works > the other way around because homebrew casks don't try to maintain anything > and just unpack and run an install script. > > On Fri, 6 Jan 2017 at 19:58 Jörg Thalheim <[email protected]> wrote: > > I actually mean the other way around. > > > On 2017-01-06 20:57, zimbatm wrote: > > Yes that's the package. It installs nix with the nixpkgs-unstable > channel. It does basically the same thing as `curl > https://nixos.org/nix/install | sh` but also provides an uninstall step. > > > > On Fri, 6 Jan 2017 at 19:21 Jörg Thalheim <[email protected] <mailto: > [email protected]>> wrote: > > > > Will there be a homebrew package for nixpkgs? > > > > > > On 2017-01-06 19:40, zimbatm wrote: > > > For the lulz I packaged nix for homebrew cask. Now you can `brew > cask install nix`. Anyways, what I wanted to highlight is that the > contributiob process was quite nice, there are probably some ideas that we > could take from them. > > > > > > There is a clear path to contribution starting from the README.md > which links to the right document. Also `brew cask create nix` was all I > needed to get the new package description opened in my $EDITOR. > > > > > > When they rejected the package it was with a link to a clear > document that lists the inclusion criteria. This also helped me appeal and > ultimately revert the decision by sharing some missing context. > > > > > > Finally during the review, the reviewer was pushing style fixes to > the PR. It was probably as quick as leaving a comment and made the whole > process much more inclusive, we were actually working together to get this > merged. > > > > > > These are just some highlights. In general I find that homebrew > has a good focus on usability. > > > > > > ---------- Forwarded message --------- > > > From: Miccal Matthews <[email protected] <mailto: > [email protected]> <mailto:[email protected] <mailto: > [email protected]>>> > > > Date: Thu, 5 Jan 2017, 11:43 > > > Subject: Re: [caskroom/homebrew-cask] Added nix 1.11.5 (#28531) > > > To: caskroom/homebrew-cask <[email protected] > <mailto:[email protected]> <mailto: > [email protected] <mailto:[email protected] > >>> > > > Cc: zimbatm <[email protected] <mailto:[email protected]> > <mailto:[email protected] <mailto:[email protected]>>>, Author < > [email protected] <mailto:[email protected]> <mailto: > [email protected] <mailto:[email protected]>>> > > > > > > > > > Merged #28531 < > https://github.com/caskroom/homebrew-cask/pull/28531>. > > > > > > — > > > You are receiving this because you authored the thread. > > > Reply to this email directly, view it on GitHub < > https://github.com/caskroom/homebrew-cask/pull/28531#event-912529758>, or > mute the thread < > https://github.com/notifications/unsubscribe-auth/AAAMsDii1OcfwpqT5gwbNWZLdZ2Ef1Soks5rPNdUgaJpZM4LaLKP > >. > > > > > > > > > > > > _______________________________________________ > > > nix-dev mailing list > > > [email protected] <mailto:[email protected]> > > > http://lists.science.uu.nl/mailman/listinfo/nix-dev > > > > _______________________________________________ > > nix-dev mailing list > > [email protected] <mailto:[email protected]> > > http://lists.science.uu.nl/mailman/listinfo/nix-dev > > > > _______________________________________________ > nix-dev mailing list > [email protected] > > http://lists.science.uu.nl/mailman/listinfo/nix-dev > >
_______________________________________________ nix-dev mailing list [email protected] http://lists.science.uu.nl/mailman/listinfo/nix-dev
