Branch: refs/heads/master
  Home:   https://github.com/NixOS/nixpkgs
  Commit: 76a3c30471e57faaa75f4ed957c12f13e9f92d90
      
https://github.com/NixOS/nixpkgs/commit/76a3c30471e57faaa75f4ed957c12f13e9f92d90
  Author: Franz Pletz <fpl...@fnordicwalking.de>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M nixos/modules/tasks/network-interfaces-scripted.nix

  Log Message:
  -----------
  network-interfaces service: fix bindsTo deps for masters

Previously, netdev units for network interfaces defined in the nixos
configurations would bindTo the systemd device unit of the interface if
not in a container.

In situations where you switch to a new nixos configration with changes
to network-setup.service (like nameservers) and have stacked interfaces
like vlans on a bond, it would fail to propagate restarts to the netdevs
correctly resulting with broken networking. The bond would be present
but no vlan interfaces rendering the machine unreachable.

My fear is that the udev events fail to propagate correctly while a systemd
transaction that is also restarting the triggered netdev service is running.
This commit changes this behaviour so netdev services bindTo other netdev
services if present and otherwise fall back to the previous behaviour.

We also noticed that stacked interfaces would sometimes seemingly be stopped
in the wrong order. For instance in the above example, the bond interface
would be deleted before the vlan interfaces resulting in the vlan interfaces
not being present when their service is being stopped. This would cause the
systemd transaction to fail and thus break networking. Their postStop hooks
are now allowed to fail as we have reached the desired state.


  Commit: 741770c99abbd6a165b5a7b0d8206aebba671de7
      
https://github.com/NixOS/nixpkgs/commit/741770c99abbd6a165b5a7b0d8206aebba671de7
  Author: Franz Pletz <fpl...@fnordicwalking.de>
  Date:   2017-02-18 (Sat, 18 Feb 2017)

  Changed paths:
    M nixos/modules/tasks/network-interfaces-scripted.nix

  Log Message:
  -----------
  network-interface service: tuntap ifs have netdev services


  Commit: c4c23f36caf91261ee316d763890a4684ef22771
      
https://github.com/NixOS/nixpkgs/commit/c4c23f36caf91261ee316d763890a4684ef22771
  Author: Franz Pletz <fpl...@fnordicwalking.de>
  Date:   2017-02-18 (Sat, 18 Feb 2017)

  Changed paths:
    M nixos/modules/tasks/network-interfaces-scripted.nix

  Log Message:
  -----------
  Merge pull request #22727 from mayflower/fix/netdev-master-bindsto

network-interfaces service: fix bindsTo deps for masters


Compare: https://github.com/NixOS/nixpkgs/compare/47c214cc2ac2...c4c23f36caf9
_______________________________________________
nix-commits mailing list
nix-comm...@lists.science.uu.nl
http://lists.science.uu.nl/mailman/listinfo/nix-commits

Reply via email to