Hello nmh-workers
I've been using nmh-1.0 for a while now with exmh. Some of the problems I
noticed have been fixed in cvs but here are the others:
+ why don't comp, forw take -fcc -cc etc?
+ (trivial) the man page for .mh_profile is mh-profile
+ on my system (RedHat 5.1) configure doesnt detect libm. It seems to compile
OK though
+ in uip/scan.c (174 onwards) isnt there a problem if nummsgs> 2 * maxmsgs ?
+ mkstemp usage is wrong. From the glib 2 info:
- Function: int mkstemp (char *TEMPLATE)
The `mkstemp' function generates a unique file name just as
`mktemp' does, but it also opens the file for you with `open'
(*note Opening and Closing Files::.). If successful, it modifies
TEMPLATE in place and returns a file descriptor open on that file
for reading and writing. If `mkstemp' cannot create a
uniquely-named file, it makes TEMPLATE an empty string and returns
`-1'. If TEMPLATE does not end with `XXXXXX', `mkstemp' returns
`-1' and does not modify TEMPLATE.
Rather than sprinkling HAVE_MKSTEMP everywhere, I think it would be better to
have a new function (say mkstemp) which got compiled #ifndef HAVE_MKSTEMP
Keep up the good work. Bye,
Richard.
ObPatch - to fix SEGV if ~/.mh_profile doesn't end in a newline
=======================================================
--- nmh/sbr/m_getfld.c Tue Aug 10 14:18:46 1999
+++ nmh/sbr/m_getfld.c Tue Aug 10 14:19:16 1999
@@ -390,7 +390,7 @@
*cp++ = j = *(iob->_ptr + c);
c = _filbuf(iob);
#endif
- if ((j == '\0' || j == '\n') && c != ' ' && c != '\t') {
+ if (c == EOF || (j == '\0' || j == '\n') && c != ' ' && c != '\t') {
if (c != EOF) {
#ifdef LINUX_STDIO
--iob->_IO_read_ptr;
