m_getfld char/unsigned char problem?

[Johan A. van Zanten]

I was compiling nmh-1.0.3 under Solaris 2.6, using Sun's cc, which warned
of the following "problem", though gcc on Solaris 2.6 and Solaris 7
didn't.

 The "m_getfld" in h/prototypes.h appears to want "unsigned char *" for
parameters 2 and 3.  But in the quite numerous files where the function is
called, these parameters seemed to be passing plain "char *".

 Anyone know which it should be, or is Sun's cc just being overly anal?

(Attached are the line from prototypes.h, and some relevant lines grep'd
from source.)

Johan van Zanten                        \ "And so once again we find that
Systems Shaman                           \ the evil of the past seeps into
Tumbleweed Electron Wranglers, Inc.       \ the present, like salad dressing 
[EMAIL PROTECTED]                       \ through cheap waxed paper."



Line 570 of h/prototypes.h:
  int m_getfld (int, unsigned char *, unsigned char *, int, FILE *);

egrep -n "m_getfld \(" */*.c | head

sbr/m_getfld.c:204:m_getfld (int state, unsigned char *name, unsigned char *buf,
sbr/readconfig.c:60:    switch (state = m_getfld (state, name, field, sizeof(field), 
ib)) {
sbr/readconfig.c:72:                    state = m_getfld (state, name, field, 
sizeof(field), ib);
sbr/seq_read.c:81:      switch (state = m_getfld (state, name, field, sizeof(field), 
fp)) {
sbr/seq_read.c:88:                      state = m_getfld (state, name, field, 
sizeof(field), fp);
uip/distsbr.c:47:               m_getfld (state, name, buffer, sizeof buffer, ifp)) {
uip/distsbr.c:64:                   state = m_getfld (state, name,
uip/distsbr.c:148:              m_getfld (state, name, buffer, sizeof buffer, ifp)) {
uip/distsbr.c:156:                  state = m_getfld (state, name,
uip/distsbr.c:177:                  state = m_getfld (state, name,


 egrep "char name" */*.c | head

sbr/m_name.c:static char name[BUFSIZ];
sbr/readconfig.c:    char name[NAMESZ], field[BUFSIZ];
sbr/seq_read.c:    char name[NAMESZ], field[BUFSIZ];
uip/distsbr.c:    char name[NAMESZ], buffer[BUFSIZ];
uip/distsbr.c:    char name[NAMESZ], buffer[BUFSIZ], tmpfil[BUFSIZ];
uip/post.c:    char namep[BUFSIZ];
uip/replsbr.c:    char name[NAMESZ], *scanl, *cp;
uip/scansbr.c:    char name[NAMESZ];
uip/sendsbr.c:    char name[NAMESZ], partnum[BUFSIZ];
uip/slocal.c:    char name[NAMESZ], field[BUFSIZ];