[email protected] wrote: > > > Thanks. This doesn't actually apply to current head of git, > > [...] > > Anyway, some nitpicking on points of detail: > >That's not nitpicking--just good code reviewing. My C skills really >suck. Sorry. > >I like everything you've said. I'll send along a better patch for >consideration soon.
Cool. One I missed is that I think we do need to have something for signal handling: with current whatnow if you hit ^C at the prompt then whatnow exits with status 1 (we catch the SIGINT and return NULL from getans() so whatnow exits cleanly). In the readline version, if you hit ^C at the prompt then whatnow exits with status 130, ie command terminated with a signal, and the caller of getans() didn't get control back. -- PMM _______________________________________________ Nmh-workers mailing list [email protected] http://lists.nongnu.org/mailman/listinfo/nmh-workers
