Thus said Stephen Gildea on Tue, 19 Nov 2024 10:03:28 -0800: > I tried out nmh-master-take-two-amb.patch of 22 Nov 2022. Sometimes it > works, and sometimes it seems to read outside the buffer, either > aborting or giving me garbage. It succeeded on a bad message from UPS, > but it failed with my enhanced test-pop test.
That's interesting to me since I've been running this very patch for over 2 years now without any corruption or "aborts" on a "live" email system. I wonder what your test-pop test does differently than real email servers. Specifically, I've been running nmh-1.8 with my patch. I would like to learn from what I may have missed that's causing your failures. Would you mind sharing some steps that I run against my own system that has my patch and your "test-pop" test? > There was one aspect of this patch that I didn't like: that popsbr.c's > expanded traverse() duplicates logic from multiline, netsec_readline > and netsec_fillread. Yes, I was not happy about duplicating some of the logic but didn't have the time to rewrite more of it. > Con: Because this change is so deep, I had to re-do the interfaces > several layers up. pop_readline(), multiline(), and callers of > multiline are all affected. This is the other reason why I opted to change it the way I did. The more I got into it, the deeper it got and it started getting quite complicated so I took what seemed to be the simpler approach. Thanks, Andy
