On Wed, 2012-09-19 at 06:51 -0700, [email protected] wrote: > On Wednesday 19 September 2012 06:12 PM, Rose, Charles wrote: > > On Wednesday 19 September 2012 05:39 PM, Rose, Charles wrote: > >> Hello, > >> > >> On RHEL 6.3, I attempted to add a package to ovirt-node-iso, but I get > >> this trace. It looks like > >> mksquashfs osmin.img is being passed '-comp None': > >> > >> # edit-node --install vim --repo ./rhel6.repo > >> ovirt-node-iso-2.5.999-999.1.el6.iso > >> ... > >> Creating Manifests > >> Copying Manifests > >> Editing Complete > >> ... > >> _ovirt-node-iso: 15171/32768 files (0.8% non-contiguous), 105637/105637 > >> blocks > >> ['/sbin/mksquashfs', '/var/tmp/edit-liveos-2Rpc0f/iso/LiveOS/osmin', > >> '/var/tmp/edit-liveos-2Rpc0f/iso/LiveOS/osmin.img', '-comp', None] > >> Traceback (most recent call last): > >> File "/usr/sbin/edit-node", line 1498, in <module> > >> sys.exit(main()) > >> File "/usr/sbin/edit-node", line 1482, in main > >> editor.package(output) > >> File "/usr/lib/python2.6/site-packages/imgcreate/creator.py", line 768, > >> in package > >> self._stage_final_image() > >> File "/usr/lib/python2.6/site-packages/imgcreate/live.py", line 302, in > >> _stage_final_image > >> create_image_minimizer(self.__isodir + "/LiveOS/osmin.img", > >> self._image, self.compress_type) > >> File "/usr/lib/python2.6/site-packages/imgcreate/fs.py", line 618, in > >> create_image_minimizer > >> mksquashfs(cowloop.lofile, path, compress_type) > >> File "/usr/lib/python2.6/site-packages/imgcreate/fs.py", line 55, in > >> mksquashfs > >> ret = subprocess.call(args) > >> File "/usr/lib64/python2.6/subprocess.py", line 478, in call > >> p = Popen(*popenargs, **kwargs) > >> File "/usr/lib64/python2.6/subprocess.py", line 639, in __init__ > >> errread, errwrite) > >> File "/usr/lib64/python2.6/subprocess.py", line 1228, in _execute_child > >> raise child_exception > >> TypeError: execv() arg 2 must contain only strings > >> > >> squashfs-tools-4.0 on RHEL does not support '-comp'. So I bumped it to > >> squashfs-tools-4.2 from > >> upstream, still see the issue. > >> > >> Based on imgcreate/fs.py, setting 'self.compress_type = gzip' in edit-node > >> seems to work. > >> > >> Is mksquashfs supposed to detect the compression type and use that? Any > >> thoughts? > >> > > > > Looks like RHEL6 EPEL has a very old version of livecd-tools. Upstream and > > Fedora have "Enable > > reading of SquashFS compression type" - > > 1aabfeae37aa87607a5e083e2775f744773619eb > > > > I built livecd-tools-17.14-1 from F17 for RHEL6 and everything works now. > > The livecd-tools version in the spec file has a '020-2'. Setting this to > '16.0' will ensure we have > support to detect compression type for squashfs. > > diff --git a/ovirt-node.spec.in b/ovirt-node.spec.in > index aa01679..d8f1ef9 100644 > --- a/ovirt-node.spec.in > +++ b/ovirt-node.spec.in > @@ -84,7 +84,7 @@ Provides a series of daemons and support utilities for > hypervisor distribution. > Summary: Recipes for building and running %{product_family} image > Group: Applications/System > Requires: pykickstart >= 1.54 > -Requires: livecd-tools >= 020-2 > +Requires: livecd-tools >= 16.0 > Obsoletes: ovirt-node-tools <= 2.3.0-999 > > %define recipe_root %{_datadir}/ovirt-node-recipe > @@ -98,7 +98,7 @@ however on a development machine to help to build the image. > %package tools > Summary: Recipes for building and running %{product_family} image > Group: Applications/System > -Requires: livecd-tools >= 020-2 > +Requires: livecd-tools >= 16.0 > > %define tools_root %{_datadir}/ovirt-node-tools > > > > > -Charles > >
Hi Charles, Thanks for the debugging. It looks like we need to pull in the livecd-tools maintainer to see if we can update the EPEL version. Brian, is this something we can get updated (livecd-tools in EPEL6)? Thanks Mike > > _______________________________________________ > node-devel mailing list > [email protected] > http://lists.ovirt.org/mailman/listinfo/node-devel _______________________________________________ node-devel mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-devel
