On 06/17/2013 03:54 PM, Fabian Deutsch wrote:
Am Montag, den 17.06.2013, 15:42 -0400 schrieb Mike Burns:
On 06/17/2013 03:34 PM, Fabian Deutsch wrote:
Am Montag, den 17.06.2013, 13:06 -0400 schrieb Mike Burns:
Things look good so far, but some questions/issues that I found:
Questions:
Is there a way to toggle bridged/direct in the TUI?
Yep, I actually don't know the patch - maybe I need to reorganize it -
but it's set in the NIC Details configuration, "Use bridge? [ ]"
Unless i missed the patch, I'm not seeing this. I did checkout of this
patch, rebased on top of latest git, and built:
http://gerrit.ovirt.org/#/c/15700/
I fixed it up in one of the bond related patches.
Issues:
Error when de-activating nic with no bridge:
3/5 Write new configuration
An error occurred while applying the changes: udev has no infos for None
Yep, also ran into that one.
Nic Config transaction says "DNS and NTP configuration" this might be
old/existing functionality
Yep, renamed it to "Basic Network Configuration", or maybe some other
wording?
NIC Configuration or Network Interface Configuration
ack
Status screen shows "Bridge: eth0"
Yep, I removed the hard coded "Bridge", now geneirc network informations
are shown.
ACK
not sure when this showed up so might be unrelated -- ovirt-node.log in
/var/log
Yes, it should be there.
Can you tell me what is in which log?
ovirt.log
ovirt-debug.log
ovirt-node.log
And can/should we consolidate?
Ah, now I see your point.
ovirt.log - our legacy logfile, it will stay around until we migrated
all legacy code.
ovirt-debug.log - debug level logger
ovirt-node.log - info level logger (much much less informations)
On the long run ovirt.log and ovirt-node.log will be "merged",
ovirt-node.debug.log can be disabled, maybe we can add a fag to enable
it ..
Ok, that makes some sense. I think making debug mode configurable makes
sense, though if we do that, we could drop ovirt-debug.log completely, I
think and just have debug logs go into the main log file.
That way, we log just info in the ovirt-node.log file and only log debug
if the configuration is set to enable debugging.
Mike
Fabian
Mike
Thanks for looking at it and your comments! I'll fix those issue in
upcoming commits.
- fabian
_______________________________________________
node-devel mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-devel
_______________________________________________
node-devel mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-devel
