Michael Burns has posted comments on this change. Change subject: spec: Create wwids on install. ......................................................................
Patch Set 1: I would prefer that you didn't submit this (3 inline comments) Couple typos in the commit message and a question in the actual code change .................................................... Commit Message Line 9: Errors are spit out at bott if /etc/multipath/wwids doesn't exist s/bott/boot Line 10: therefor we create it at install time. s/therefor/therefore .................................................... File ovirt-node.spec.in Line 260: touch /etc/multipath/wwids are permissions right? On a rhel 6 host: # ls -l /etc/multipath/wwids -rw-------. 1 root root 1665 Feb 22 18:06 /etc/multipath/wwids -- To view, visit http://gerrit.ovirt.org/3097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8bf1db955ac274839b0a7047d66344c5e3743cd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Michael Burns <[email protected]> _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
