Michael Burns has posted comments on this change.

Change subject: [DRAFT] boot: Add another service for autotesting
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File scripts/ovirt-init-functions.sh
Line 1359:         TESTSUITE=$(egrep 'testsuite=.[^[:space:]]')
what are you grepping?

probably simpler to add handling to ovirt-early to put the value in 
/etc/default/ovirt and read from there.

Line 1360:         if $TESTSUITE; then
should be if [ $? = 0 ]; then

--
To view, visit http://gerrit.ovirt.org/4306
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77969d53902e4837e90f1644f68338f1b7f47741
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Michael Burns <[email protected]>
_______________________________________________
node-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-patches

Reply via email to