Fabian Deutsch has posted comments on this change.

Change subject: Use rd.live.check on Fedora
......................................................................


Patch Set 2: (2 inline comments)

Basically fine, but maybe we could also add the rd.lvm=0 (instead of RD_NO_LVM 
or what it is now) karg with this patch.

....................................................
Commit Message
Line 7: Use rd.live.check on Fedora
Line 8: 
Line 9: "check" is deprecated as a bootloader option. Use "rd.live.check"
Line 10: instead.
Line 11: rhbz#902424
please use the Bug-Url: syntax
Line 12: 
Line 13: Change-Id: Ic98457d7f02bf404128e19ef04af05481ac2adb4


....................................................
File configure.ac
Line 81:                 logrotate/Makefile
Line 82:                 modules/Makefile
Line 83:                 plugins/Makefile
Line 84:                 $MAIN_KS
Line 85:                recipe/common-install.ks
please use spaces like the other lines do
Line 86:                 recipe/image-minimizer.ks
Line 87:                 scripts/ovirt-functions
Line 88:                 scripts/ovirt-init-functions.sh
Line 89:                 semodule/ovirt.te


-- 
To view, visit http://gerrit.ovirt.org/15585
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic98457d7f02bf404128e19ef04af05481ac2adb4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
node-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-patches

Reply via email to