Fabian Deutsch has uploaded a new change for review. Change subject: ui: No on_change on Table(multi) focus change ......................................................................
ui: No on_change on Table(multi) focus change Previously an on_change event (which triggered an on_save() call) was emitted when the focus in a Table with multiple-options changed from one focus to the next. But this behaviour was incorrect. NodePlugin.on_save() shall only be called when the data model change, so when the user actualy changes data e.g. selects another entry or deselects one. The on_change is now only called - in a user with multi=True - when the user selects or deselects an entry. To capture focus shifts/changing entries the Table.on_change signals has to be used directly. Change-Id: Ic6d9fc2ca9dbcbb4ee009ebc3b7e342a9e44c66c Signed-off-by: Fabian Deutsch <[email protected]> --- M src/ovirt/node/ui/__init__.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/82/18382/1 diff --git a/src/ovirt/node/ui/__init__.py b/src/ovirt/node/ui/__init__.py index 6159575..e80d1d0 100644 --- a/src/ovirt/node/ui/__init__.py +++ b/src/ovirt/node/ui/__init__.py @@ -595,6 +595,7 @@ if multi: self.selection(selected_item or []) self.on_activate.connect(ChangeAction()) + self.on_change.clear() else: if selected_item or self.items: self.selection(selected_item or self.items[0][0]) -- To view, visit http://gerrit.ovirt.org/18382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic6d9fc2ca9dbcbb4ee009ebc3b7e342a9e44c66c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <[email protected]> _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
