Fabian Deutsch has submitted this change and it was merged. Change subject: ui: Rework validation and exception handling ......................................................................
ui: Rework validation and exception handling Previously the actual widget of a toolkit was responsible to call and handle the validation stuff. The pros of this approach were that e.g. handling simple validation errors was easy and could be directly implemented by the widget. Problems arose with the introduction with e.g. the ConfirmedEntry (which is a complex ui.Element in the UI abstraktion layer). With the introduction of these complex ui.Elements we also wanted - and needed - to pull the validation and exception handling into the UI abstraction layer. This is necessary because now it can be controlle din the UI abstraction layer how invalid data shall be handled. Change-Id: I4542a2641c6ce6f9f9126db608abca57a4ca453b Signed-off-by: Fabian Deutsch <[email protected]> --- M src/ovirt/node/app.py M src/ovirt/node/base.py M src/ovirt/node/installer/core/boot_device_page.py M src/ovirt/node/installer/core/installation_device_page.py M src/ovirt/node/installer/core/progress_page.py M src/ovirt/node/installer/core/upgrade_page.py M src/ovirt/node/plugins.py M src/ovirt/node/setup/cim/cim_page.py M src/ovirt/node/setup/core/security_page.py M src/ovirt/node/setup/snmp/snmp_page.py M src/ovirt/node/ui/__init__.py M src/ovirt/node/ui/urwid_builder.py 12 files changed, 287 insertions(+), 247 deletions(-) Approvals: Fabian Deutsch: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18277 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4542a2641c6ce6f9f9126db608abca57a4ca453b Gerrit-PatchSet: 10 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
