Fabian Deutsch has posted comments on this change.
Change subject: kdump_page: Catch KeyboardInterrupt when inputting "Ctrl+c"
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
....................................................
File src/ovirt/node/setup/core/kdump_page.py
Line 172: model.update(None, None, None)
Line 173: txs = model.transaction()
Line 174: console.reset()
Line 175: is_dry = self.application.args.dry
Line 176: progress_dialog = console.TransactionProgress(txs,
is_dry)
I wouldn't just rerun the new trnasaction in a new transaction runner.
We should give the user some feedback that the previous transaction got aborted
and the configuration got removed / the configuration is left in a clean state.
I'd probably run the tx silently. so just doing tx()
Line 177: progress_dialog.run()
Line 178: console.writeln("\nPlease press any key to continue")
Line 179: console.wait_for_keypress()
Line 180: except Exception as e:
--
To view, visit http://gerrit.ovirt.org/18491
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7af3fc071db96a3c57c1b9fb76f4c3574250bef6
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
node-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-patches
