Fabian Deutsch has submitted this change and it was merged. Change subject: Check if shell in kwargs is actually true instead of just present ......................................................................
Check if shell in kwargs is actually true instead of just present Previously, process.__check_for_problems only looked for the existence of "shell" as a kwarg, but the service call explicitly sets shell to False. See whether or not it's true before we throw a runtime error. Change-Id: I12d7e73b18b0e23335b5f481d0e06d302f5b1438 Bug-Url: http://bugizlla.redhat.com/show_bug.cgi?id=1010629 Signed-off-by: Ryan Barry <[email protected]> --- M src/ovirt/node/utils/process.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Fabian Deutsch: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12d7e73b18b0e23335b5f481d0e06d302f5b1438 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
