Fabian Deutsch has posted comments on this change.
Change subject: Get serial console working on Fedora and add TUI configuration
......................................................................
Patch Set 5:
(1 comment)
....................................................
File src/ovirt/node/setup/core/status_page.py
Line 289: utils.process.check_call("mount -o ro,remount %s" %
Line 290: self.find_mount(grub_path),
shell=True)
Line 291:
Line 292: def __find_mount(self, path):
Line 293: while not os.path.ismount(path) and os.path != "/":
Okay, let me rephrase:
Why is this loop needed at all?
I imaginge something like: Wait for the path to become a mount target.
And how do we break out of this loop if path does not become a mount target?
Line 294: path = os.path.dirname(path)
Line 295: return path
Line 296:
Line 297:
--
To view, visit http://gerrit.ovirt.org/17982
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id99623830b56b77815196c8b0d153c86d3704f00
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Joey Boggs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
node-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-patches
