Ryan Barry has posted comments on this change.

Change subject: Validate passed NTP servers and reject bad ones
......................................................................


Patch Set 2:

(1 comment)

....................................................
File scripts/ovirt-init-functions.sh.in
Line 655:             validservers.append(x)
Line 656: print ",".join(validservers)
Line 657: EOP
Line 658: `")
Line 659:             ;;
Not especially. It was somewhat heavily golfed to fit into 
ovirt-init-functions. With nested transactions working, it'll be moved out to 
somewhere it's easier to deal with exceptions.
Line 660:             network_layout=*)
Line 661:             network_layout=${i#network_layout=}
Line 662:             ;;
Line 663:             bond=*)


-- 
To view, visit http://gerrit.ovirt.org/17888
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb135977b4359f5fe0161215cec2cdd1b22244b3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Joey Boggs <[email protected]>
Gerrit-Reviewer: Ryan Barry <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
node-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-patches

Reply via email to