Ryan Barry has posted comments on this change.
Change subject: Fix only calculate one disk driver size issue
......................................................................
Patch Set 6: Code-Review-1
(1 comment)
....................................................
File src/ovirtnode/storage.py
Line 188: for drive in drives:
Line 189: drives_size += int(self.get_drive_size(drive))
Line 190: logger.debug(drives_size)
Line 191: return drives_size
Line 192:
Rather than putting this in the old codebase, it would be better to have it
either on the installer plugin page itself (since this code path may not get
used anywhere else), or in ovirt.node.utils
Line 193: def _lvm_name_for_disk(self, disk):
Line 194: name = None
Line 195: cmd = "lvm pvs --noheadings --nameprefixes --unquoted -o
pv_name,vg_name '%s' 2> /dev/null" % disk
Line 196: lines = str(_functions.passthrough(cmd)).strip().split("\n")
--
To view, visit http://gerrit.ovirt.org/18439
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I387c6832be086ac6895c94282d1ed711d02500ec
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <[email protected]>
Gerrit-Reviewer: Joey Boggs <[email protected]>
Gerrit-Reviewer: Ryan Barry <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
node-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-patches
