Ryan Barry has posted comments on this change.
Change subject: progress_page:fix missed persist /etc/vconsole.conf and
/etc/sysconfig/keyboard
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
....................................................
File src/ovirt/node/installer/core/progress_page.py
Line 280: def commit(self):
Line 281: model = defaults. Keyboard()
Line 282: model.update(layout=self.kbd_layout)
Line 283: tx = model.transaction()
Line 284: tx()
Semantics, but could we:
model = defaults.Keyboard().update(layout=self.kbd_layout)
model.transaction().run()
--
To view, visit http://gerrit.ovirt.org/20054
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67ee6eb7287db7a909469a9820508bd3e1835cb2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Ryan Barry <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
node-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-patches
