Fabian Deutsch has posted comments on this change.
Change subject: Validate "Other Device" against live device
......................................................................
Patch Set 17: Code-Review-1
(1 comment)
Looks basically, fine except the thread change.
....................................................
File src/ovirt/node/installer/core/boot_device_page.py
Line 31:
Line 32: def __init__(self, app):
Line 33: super(Plugin, self).__init__(app)
Line 34: self.storage_discovery = StorageDiscovery(app.args.dry)
Line 35: self.storage_discovery.start()
Please maek this change in another patch. Just to be on the save side when
reverting :)
Line 36:
Line 37: def name(self):
Line 38: return _("Boot Device")
Line 39:
--
To view, visit http://gerrit.ovirt.org/19879
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b87876876965418765cbb6a0c0030bf143f156
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
node-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-patches