Hello hadong,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/24772

to review the following change.

Change subject: Clear password.info text when giving new password
......................................................................

Clear password.info text when giving new password

Change-Id: I4a888e96bb6822912bd97fe81de85f43587d51eb
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1018448
Signed-off-by: hadong <[email protected]>
---
M src/ovirt/node/installer/core/upgrade_page.py
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/72/24772/1

diff --git a/src/ovirt/node/installer/core/upgrade_page.py 
b/src/ovirt/node/installer/core/upgrade_page.py
index 518a020..df537d5 100644
--- a/src/ovirt/node/installer/core/upgrade_page.py
+++ b/src/ovirt/node/installer/core/upgrade_page.py
@@ -71,6 +71,14 @@
         return page
 
     def on_change(self, changes):
+        if changes.contains_any(["upgrade.password"]):
+            self._model.update(changes)
+            up_pw = self._model.get("upgrade.password", "")
+            if up_pw:
+                self.widgets["password.info"].text("")
+            else:
+                self.widgets["password.info"].text(self.__no_new_password_msg)
+
         if changes.contains_any(["upgrade.current_password"]):
             # Hide any message which was shown
             self.widgets["current_password.info"].text("")


-- 
To view, visit http://gerrit.ovirt.org/24772
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a888e96bb6822912bd97fe81de85f43587d51eb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: node-3.0
Gerrit-Owner: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: hadong <[email protected]>
_______________________________________________
node-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-patches

Reply via email to