Fabian Deutsch has posted comments on this change.

Change subject: kdump_page: enable "ssh_key" entry when selecting "SSH" type
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/24537/1/src/ovirt/node/setup/core/kdump_page.py
File src/ovirt/node/setup/core/kdump_page.py:

Line 136:             if w in net_types and w in self.widgets:
Line 137:                 self.widgets[w].enabled(True)
Line 138:                 self.widgets[w].value(self._model[w])
Line 139:                 if w == "kdump.ssh_location":
Line 140:                     self.widgets["kdump.ssh_key"].enabled(True)
And when does the widget get disabled again?
Line 141: 
Line 142:     def on_merge(self, effective_changes):
Line 143:         """Applies the changes to the plugins model, will do all 
required logic
Line 144:         Normally on_merge is called by pushing the SaveButton 
instance, in this


-- 
To view, visit http://gerrit.ovirt.org/24537
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d03271f75681e0b7d0279d123538d56e12a698d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
node-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-patches

Reply via email to