Fabian Deutsch has uploaded a new change for review.

Change subject: installer: Require input on custom device dialog
......................................................................

installer: Require input on custom device dialog

Previously the user could save the custom device dialog even if he
didn't input a device path, this lead to an exception.
Now the user is required to input a valid device path before he can save
the dialog.

Change-Id: I075dd7c5643b7b8ec716166699e21f8f273e55f3
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1065894
Signed-off-by: Fabian Deutsch <[email protected]>
---
M src/ovirt/node/installer/core/boot_device_page.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/83/25183/1

diff --git a/src/ovirt/node/installer/core/boot_device_page.py 
b/src/ovirt/node/installer/core/boot_device_page.py
index 78e514a..cd5a8f6 100644
--- a/src/ovirt/node/installer/core/boot_device_page.py
+++ b/src/ovirt/node/installer/core/boot_device_page.py
@@ -229,6 +229,7 @@
                     device_entry]
         super(CustomDeviceDialog, self).__init__("%s.dialog" % path_prefix,
                                                  title, children)
-        self.buttons = [ui.SaveButton("dialog.device.custom.save", _("Save")),
+        self.buttons = [ui.SaveButton("dialog.device.custom.save", _("Save"),
+                                      enabled=False),
                         ui.CloseButton("dialog.device.custom.close",
                                        _("Cancel"))]


-- 
To view, visit http://gerrit.ovirt.org/25183
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I075dd7c5643b7b8ec716166699e21f8f273e55f3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <[email protected]>
_______________________________________________
node-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-patches

Reply via email to