Fabian Deutsch has posted comments on this change. Change subject: Add parameters and code to back kdump autoinstall parameters ......................................................................
Patch Set 10: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/17894/10/scripts/ovirt-auto-install.py File scripts/ovirt-auto-install.py: Line 159: title = "Configuring KDump" Line 160: Line 161: def commit(self): Line 162: try: Line 163: model = defaults.KDump() I believe the KDUmp class now has configure functions for the specific "backends" (ssh, nfs, local) please update the patch to use these. The reasoning behind this is to keep the "logic" (what args to set to e.g. configure ssh+key) in one place, Line 164: Line 165: if "OVIRT_KDUMP_SSH" in OVIRT_VARS and \ Line 166: "OVIRT_KDUMP_SSH_KEY" in OVIRT_VARS: Line 167: model.update(None, OVIRT_VARS["OVIRT_KDMP_SSH"], -- To view, visit http://gerrit.ovirt.org/17894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide8d438aa19f0189a4d3d37399ffd57cd8774584 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
