Fabian Deutsch has posted comments on this change.

Change subject: Fix snmp/cim page refresh issue
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/26423/1/src/ovirt/node/ui/__init__.py
File src/ovirt/node/ui/__init__.py:

Line 460:     def __init__(self, path, label="Close", enabled=True):
Line 461:         super(CloseButton, self).__init__(path, label, enabled)
Line 462:         self.on_activate.clear()
Line 463:         self.on_activate.connect(CloseAction())
Line 464:         self.on_activate.connect(ReloadAction())
This basically makes a page reload the default for all close buttons. I do't 
want to do this.

Please attach it only to the buttons where this is necessary (so cim and snmp)
Line 465: 
Line 466: 
Line 467: class QuitButton(Button):
Line 468:     """The quit button can be used to quit the whole application


-- 
To view, visit http://gerrit.ovirt.org/26423
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23207ae0a47d2108edb750cbdd4a2c4fbca6236b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
node-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-patches

Reply via email to