Fabian Deutsch has posted comments on this change. Change subject: Prompt more friendly information when enabling puppet failure ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26422/1/src/ovirt/node/setup/puppet/puppet_page.py File src/ovirt/node/setup/puppet/puppet_page.py: Line 171: utils.process.check_call("puppet agent --waitforcert 60 --test", Line 172: shell=True) Line 173: system.service("puppet", "start") Line 174: fs.Config().persist("/var/lib/puppet") Line 175: except: In general fine, but please log the error for debugging, i.e.: except: self.logger.debug("Puppet conf failed", exc_info=True) raise RuntimeError(...) Line 176: raise RuntimeError("Synchronization with the puppet master timed " Line 177: "out.\nCheck whether a certificate is waiting " Line 178: "for signing on the master or a certificate " Line 179: "for this hostname already exists and needs to" -- To view, visit http://gerrit.ovirt.org/26422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddc1c1e74178ab4a9dd7bb23733636377eafc5ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: hadong <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
