Fabian Deutsch has posted comments on this change. Change subject: Don't break existing loggers when ovirt.node.log is imported ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/27270/1/src/ovirt/node/log.py File src/ovirt/node/log.py: Line 67: format=%(levelname)10s %(asctime)s %(pathname)s:%(lineno)s:%(funcName)s: \ Line 68: %(message)s Line 69: """) Line 70: logging.debug("Setting log config to: %s" % mixedfile) Line 71: logging.config.fileConfig(mixedfile, disable_existing_loggers=False) Mh. Basically correct to fix the bug .... The reason I didn't do this is because of the old ovirtnode logging .... But probably this is okay. Needs intensive checking. Line 72: Line 73: Line 74: def getLogger(name=None): Line 75: if not getLogger._logger: -- To view, visit http://gerrit.ovirt.org/27270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib91496239b8cc4c0096214127fa461e12b266dcb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: Ryan Barry <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
