hadong has posted comments on this change.
Change subject: Add a confirmation page
......................................................................
Patch Set 10:
Hey rbarry,
We should make sure list "LVM.VG(vg).tags" changed into a string before check
"storage_domain" in it or not.
>>> "storage_domain" in " ".join([s.strip() for s in
>>> process.check_output(["lvm", "vgs", "--noheadings", "-o", "tags",
>>> "290a39a4-f0c3-4bb4-aba0-4002aaac1049"]).split("\n")])
True
>>> "storage_domain" in [s.strip() for s in process.check_output(["lvm", "vgs",
>>> "--noheadings", "-o", "tags",
>>> "290a39a4-f0c3-4bb4-aba0-4002aaac1049"]).split("\n")]
False
--
To view, visit http://gerrit.ovirt.org/27074
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If0c099fbfbfda9bc609a024964905ee59e04280f
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <[email protected]>
Gerrit-Reviewer: Fabian Deutsch <[email protected]>
Gerrit-Reviewer: Ryan Barry <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: hadong <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
node-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/node-patches
