Ryan Barry has posted comments on this change. Change subject: Miss to unmount_config "/etc/profile" before edit it ......................................................................
Patch Set 1: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/28074/1/src/ovirt/node/utils/security.py File src/ovirt/node/utils/security.py: Line 120: if additional_lines: Line 121: self.logger.debug("Updating /etc/profile") Line 122: lines = "\n" + "\n".join(additional_lines) Line 123: File("/etc/profile").write(lines, "a") Line 124: ofunc.ovirt_store_config("/etc/profile") Please use utils.fs.Config().persist("/etc/profile") Line 125: Line 126: self.restart() Line 127: Line 128: def disable_aesni(self, disable=None): Line 173: value = "yes" if enable else "no" Line 174: self.logger.debug("Setting SSH PasswordAuthentication to " + Line 175: "%s" % value) Line 176: aug.set(augpath, value) Line 177: ofunc.ovirt_store_config("/etc/ssh/sshd_config") utils.fs.Config Line 178: self.restart() Line 179: state = str(aug.get(augpath)).lower() Line 180: if state not in ["yes", "no", "none"]: Line 181: raise RuntimeError("Failed to set SSH password authentication" + -- To view, visit http://gerrit.ovirt.org/28074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I479be705f991f7d2542a944d0491e9ac252dc410 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node Gerrit-Branch: master Gerrit-Owner: hadong <[email protected]> Gerrit-Reviewer: Ryan Barry <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ node-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/node-patches
